Skip to content

feat(CC-batch-4): added batch 4#11830

Merged
nicolethoen merged 29 commits into
patternfly:mainfrom
mattnolting:feat-CC-batch-4
Aug 26, 2025
Merged

feat(CC-batch-4): added batch 4#11830
nicolethoen merged 29 commits into
patternfly:mainfrom
mattnolting:feat-CC-batch-4

Conversation

@mattnolting

@mattnolting mattnolting commented May 13, 2025 •
edited by evwilkin
Loading

Copy link
Copy Markdown
Contributor

Relates to: #11624

Included components:

  • Banner
  • Brand
  • Breadcrumbs
  • CodeBlock
  • CodeEditor
  • Data List
  • Description List
  • Divider
  • Drawer
  • Dual List Selector

Component tracker

Figma preview

Resources:

@patternfly-build

patternfly-build commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://patternfly-react-pr-11830.surge.sh

A11y report: https://patternfly-react-pr-11830-a11y.surge.sh

Preview: https://pf-react-pr-11830.surge.sh

A11y report: https://pf-react-pr-11830-a11y.surge.sh

@mattnolting mattnolting changed the title Feat cc batch 4 feat(CC-batch-4): added batch 4 May 13, 2025
@mattnolting
mattnolting force-pushed the feat-CC-batch-4 branch 2 times, most recently from d082d8c to 9e4b7e6 Compare May 22, 2025 17:23
@mattnolting
mattnolting marked this pull request as ready for review May 22, 2025 17:24
nicolethoen
nicolethoen requested changes May 28, 2025
View reviewed changes
Comment thread packages/code-connect/components/DataList/DataList.figma.tsx Outdated
Comment thread packages/code-connect/components/DataList/DataListRow.figma.tsx Outdated
Comment thread packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx Outdated
Comment thread packages/code-connect/components/DescriptionList/TermLabel.figma.tsx Outdated
Comment thread packages/code-connect/components/Divider/Divider.figma.tsx Outdated
Comment thread packages/code-connect/components/Drawer/DrawerMain.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListHeader.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListItemBaseComponent.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx Outdated
kmcfaul
kmcfaul reviewed May 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DataList/DataList.figma.tsx Outdated
Comment thread packages/code-connect/components/DataList/DataListRow.figma.tsx Outdated
Comment thread packages/code-connect/components/DataList/DataListRow.figma.tsx Outdated
Comment thread packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx
Comment thread packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx Outdated
Comment thread packages/code-connect/components/Drawer/DrawerContent.figma.tsx Outdated
Comment thread packages/code-connect/components/Drawer/DrawerMain.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListItemBaseComponent.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx Outdated
Comment thread packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx Outdated
nicolethoen
nicolethoen requested changes Jun 12, 2025
View reviewed changes

@nicolethoen nicolethoen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of outstanding comments in this PR. i will wait to finish rereviewing it

Comment thread packages/code-connect/components/DataList/DataListRow.figma.tsx Outdated
Comment thread packages/code-connect/components/DataList/DataListRow.figma.tsx Outdated
@mattnolting
mattnolting marked this pull request as draft June 17, 2025 14:53
@mattnolting
mattnolting marked this pull request as ready for review June 24, 2025 15:22
mattnolting
mattnolting commented Jul 10, 2025
View reviewed changes
Comment thread packages/code-connect/components/DataList/_2BaseComponentsControlCell.figma.tsx Outdated
mattnolting
mattnolting commented Jul 10, 2025
View reviewed changes
Comment thread packages/code-connect/components/DataList/_2BaseComponentsContentCell.figma.tsx Outdated
mattnolting
mattnolting commented Jul 15, 2025
View reviewed changes
Comment thread packages/code-connect/components/DescriptionList/DescriptionListInCard.figma.tsx Outdated
mattnolting
mattnolting commented Jul 15, 2025
View reviewed changes
Comment thread packages/code-connect/components/Drawer/Drawer.figma.tsx Outdated
mattnolting
mattnolting commented Jul 15, 2025
View reviewed changes
Comment thread packages/code-connect/components/Drawer/Drawer.figma.tsx
mattnolting
mattnolting commented Jul 18, 2025
View reviewed changes
Comment thread packages/code-connect/components/Drawer/Drawer.figma.tsx Outdated
@mattnolting

mattnolting commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Need to remove Banner - breadcrumb - codeblock - codeEditor

These are all in Batch-3

mattnolting
mattnolting commented Jul 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DescriptionList/DescriptionListInCard.figma.tsx Outdated
mattnolting
mattnolting commented Jul 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DescriptionList/TermLabel.figma.tsx Outdated
mattnolting
mattnolting commented Jul 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DescriptionList/TermLabel.figma.tsx Outdated
mattnolting
mattnolting commented Jul 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx Outdated
mattnolting
mattnolting commented Jul 29, 2025
View reviewed changes
Comment thread packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx Outdated
mattnolting
mattnolting commented Aug 12, 2025
View reviewed changes
Comment thread packages/code-connect/components/DataList/_1BuildItYourselfClickableRows.figma.tsx Outdated
@mattnolting
feat(CC-batch-4): updated dual list
b4ce6e9
@mattnolting
feat(CC-batch-4): drawer and divider notes
6a746ba
@mattnolting
feat(CC-batch-4): removed isCompact from row
a119364
@mattnolting
feat(CC-batch-4): updated dual list uris
c739764
@mattnolting
feat(CC-batch-4): removed unneccesary props
8c07acc
@mattnolting
feat(CC-batch-4): updated panel content as prop
9ab4dd9
@mattnolting
feat(CC-batch-4): removed dualListSelectorMain
d07c01d
@mattnolting
feat(CC-batch-4): updated required props
68a66a0
@mattnolting
feat(CC-batch-4): verification complete
ab0614f
@mattnolting
feat(CC-batch-4): removed unnecessary description list files
1fea9ca
@mattnolting
feat(CC-batch-4): review-athon round 1 followup
9d7da98
@mattnolting
feat(CC-batch-4): review-athon round 1 followup
34b7d14
@mattnolting
feat(CC-batch-4): review-athon round 2 followup
d6b82a7
@mattnolting
feat(CC-batch-4): review-athon round 2 followup
ae5bee3
@mattnolting
feat(CC-batch-4): remove data list, misconfigured
ff84a09
@mattnolting
feat(CC-batch-4): review-athon round 2 followup
44f7fb3
@mattnolting
feat(CC-batch-4): review-athon round 2 followup
69baddd
@mattnolting
feat(CC-batch-4): review-athon round 2 followup
5290dc2
@mattnolting
feat(CC-batch-4): review-athon round 3 followup
d8ad549
@mattnolting
feat(CC-batch-4): review-athon round 3 followup
72519c9
@mattnolting
feat(CC-batch-4): preparing rebase
bf461f6
@mattnolting
feat(CC-batch-4): group review 4 followup
582cb3a
@mattnolting
feat(CC-batch-4): group review 5 updates
fe176ef
@nicolethoen
nicolethoen merged commit 6dac73a into patternfly:main Aug 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes
@kmcfaul kmcfaul kmcfaul approved these changes
@evwilkin evwilkin Awaiting requested review from evwilkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattnolting @patternfly-build @nicolethoen @kmcfaul